Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(one-zero): transaction identifier #879

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Conversation

tomerroditi
Copy link
Contributor

added an identifier field to the returned object from OneZero fetchPortfolioMovements

added an `identifier` field to the returned object from OneZero `fetchPortfolioMovements`
@tomerroditi tomerroditi changed the title OneZero transaction identifier fix: OneZero transaction identifier Aug 16, 2024
@tomerroditi tomerroditi changed the title fix: OneZero transaction identifier fix(one-zero) transaction identifier Aug 16, 2024
@tomerroditi tomerroditi changed the title fix(one-zero) transaction identifier fix(one-zero): transaction identifier Aug 16, 2024
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a reviewer for OneZero Bank (see #830).

Can I add you to the list?

@tomerroditi
Copy link
Contributor Author

Sure I can help with that. I'm not used to work with TS, I use python and now I'm slowly learning JS/TS for this project. will do my best :)

@baruchiro baruchiro merged commit 4315476 into eshaham:master Sep 8, 2024
6 checks passed
Copy link

github-actions bot commented Sep 8, 2024

🎉 This PR is included in version 5.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants